Skip to content

Add Install Gateway section in Getting Started Latest guide #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

Add Install Gateway section in Getting Started Latest guide #1759

merged 1 commit into from
Nov 3, 2025

Conversation

@dharaneeshvrd
Copy link
Contributor

@dharaneeshvrd dharaneeshvrd commented Oct 22, 2025

  • Move instructions from the Deploy an Inference Gateway section describing installation of Gateway API CRDs and provider specific GWs

What type of PR is this?

What this PR does / why we need it:
#1752

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2025
@netlify
Copy link

netlify bot commented Oct 22, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit c43b1d2
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6904364a21b29300082aae16
😎 Deploy Preview https://deploy-preview-1759--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 22, 2025
@nirrozenbaum
Copy link
Contributor

nirrozenbaum commented Oct 22, 2025

@dharaneeshvrd can you please rebase?
there were a few changes to the quickstart

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2025
@dharaneeshvrd dharaneeshvrd force-pushed the add-installGW-in-latest-version branch from 1e022b2 to 9240af2 Compare October 23, 2025 04:34
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2025
@dharaneeshvrd
Copy link
Contributor Author

dharaneeshvrd commented Oct 23, 2025

@nirrozenbaum Done, can you please take a look?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2025
@nirrozenbaum
Copy link
Contributor

nirrozenbaum commented Oct 28, 2025

@dharaneeshvrd really apologize, had unexpected urgent tasks and I didn't get to review it last week and now rebase is needed again.. can you please rebase? 🙏
sorry for the inconvenience.

@dharaneeshvrd dharaneeshvrd force-pushed the add-installGW-in-latest-version branch from 9240af2 to bdcd2d1 Compare October 28, 2025 16:23
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2025
@dharaneeshvrd
Copy link
Contributor Author

dharaneeshvrd commented Oct 28, 2025

@nirrozenbaum
Sure np, rebased again, ptal!

@dharaneeshvrd
Copy link
Contributor Author

dharaneeshvrd commented Oct 29, 2025

@danehans If you get a chance, can you please take a look at the changes?

nirrozenbaum
nirrozenbaum reviewed Oct 29, 2025
View reviewed changes
site-src/guides/getting-started-latest.md
```
Choose one of the following options to deploy an Inference Gateway.

=== "GKE"
Copy link
Contributor

@nirrozenbaum nirrozenbaum Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section doesn't seem to be identical to the released quickstart

Copy link
Contributor Author

@dharaneeshvrd dharaneeshvrd Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sry, was busy with other work, fixed it now, ptal!

@dharaneeshvrd
Add Install Gateway section in Getting Started Latest guide
c43b1d2 
- Move instructions from the Deploy an Inference Gateway section describing installation of Gateway API CRDs and provider specific GWs

Signed-off-by: Dharaneeshwaran Ravichandran <[email protected]>
@dharaneeshvrd dharaneeshvrd force-pushed the add-installGW-in-latest-version branch from bdcd2d1 to c43b1d2 Compare October 31, 2025 04:08
@nirrozenbaum
Copy link
Contributor

nirrozenbaum commented Nov 3, 2025

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharaneeshvrd, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit cacc5aa into kubernetes-sigs:main Nov 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirrozenbaum nirrozenbaum nirrozenbaum left review comments

@danehans danehans Awaiting requested review from danehans

@kfswain kfswain Awaiting requested review from kfswain

Assignees

@nirrozenbaum nirrozenbaum

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dharaneeshvrd @nirrozenbaum @k8s-ci-robot